Some minor test corrections #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
commented
Aug 15, 2018
| ) | ||
|
|
||
| property("validate numbers") { | ||
| forAll(tests) { d => | ||
| forAll { d: Double => |
There was a problem hiding this comment.
@ajayborra this will automatically magnet generator for any arbitrary d: Double
tovbinm
commented
Aug 15, 2018
| } | ||
|
|
||
| property("validate special numbers") { | ||
| forAll(specials) { d => |
There was a problem hiding this comment.
@ajayborra here we explicitly pass in specials table
tovbinm
commented
Aug 15, 2018
| val listener = new OpSparkListener(sc.appName, sc.applicationId, "testRun", Some("tag"), Some("tagValue"), true, true) | ||
| sc.addSparkListener(listener) | ||
| spark.read.csv(s"$testDataDir/PassengerDataAll.csv") | ||
| val _ = spark.read.csv(s"$testDataDir/PassengerDataAll.csv").count() |
There was a problem hiding this comment.
actually running some job here, i.e count rows
There was a problem hiding this comment.
Good point, Saw the changes below
tovbinm
commented
Aug 15, 2018
| @@ -43,8 +43,9 @@ class RichTupleTest extends FlatSpec with TestCommon { | |||
| res.get shouldBe 3 | |||
| } | |||
|
|
|||
| it should "not map empty tuples" in { | |||
| assertDoesNotCompile("(None, None).map((x, y) => x + y)") | |||
| it should "map on empty tuples" in { | |||
There was a problem hiding this comment.
(None, None).map actually works if the types are set, so I corrected the test.
ajayborra
reviewed
Aug 15, 2018
|
|
||
| val specials = Table("specials", | ||
| Double.MinValue, Double.MaxValue, | ||
| Double.MinPositiveValue, Double.MinPositiveValue, Double.NaN, |
There was a problem hiding this comment.
Double.MinPositiveValue is repeated.
ajayborra
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.